Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Feedback for showing submit errors on Shop Editor #675

Closed
lucca65 opened this issue Jan 19, 2022 · 1 comment
Closed

Use Feedback for showing submit errors on Shop Editor #675

lucca65 opened this issue Jan 19, 2022 · 1 comment
Labels
🧰 enhancement Changes and improvements to what we already have 👶 good first issue Good for newcomers

Comments

@lucca65
Copy link
Member

lucca65 commented Jan 19, 2022

What we have
Right now we show a basic, small red text above submit buttons on this form when we have an error

Proposal
Use Feedback to display errors

Why
Sometimes its hard to see the error message

How
We can use the existing Feedback on LoggedIn to display transactions errors. This way we have a standard way of doing this and also will have a way to report errors to sentry

Additional context
Here is a print of how an error looks like now:
Captura de Tela 2022-01-19 às 18 24 57
@lucca65 lucca65 added 🧰 enhancement Changes and improvements to what we already have 👶 good first issue Good for newcomers labels Jan 19, 2022
@lucca65 lucca65 mentioned this issue Jan 19, 2022
Merged
6 tasks
@henriquecbuss
Copy link
Member

This was fixed by #658, so I'm closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧰 enhancement Changes and improvements to what we already have 👶 good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucca65 @henriquecbuss