Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elm-review to elm-book #809

Closed
henriquecbuss opened this issue Aug 12, 2022 · 0 comments · Fixed by #827
Closed

Add elm-review to elm-book #809

henriquecbuss opened this issue Aug 12, 2022 · 0 comments · Fixed by #827
Assignees
Labels
🧰 enhancement Changes and improvements to what we already have

Comments

@henriquecbuss
Copy link
Member

What we have
We have a really nice elm-review config in our app. However, we're not using that config on our elm-book

Proposal
Use the same review config (or at least a similar one) on elm-book. We should also run it on our CI

Why
Because elm-review is awesome, and we should use it

How
If elm-review supports it, we could just use the same config, but point at a different elm project. Otherwise, maybe we could use UNIX symbolic links (we already do this for some files on elm-book)

Additional context
Discovered we're not running elm-review on elm-book during #805

@henriquecbuss henriquecbuss added the 🧰 enhancement Changes and improvements to what we already have label Aug 12, 2022
@lucca65 lucca65 added this to the 🧹 Housekeeping milestone Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧰 enhancement Changes and improvements to what we already have
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants