Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support listening on all interfaces #30

Closed
williamjacksn opened this issue Dec 7, 2018 · 1 comment · Fixed by #31
Closed

Support listening on all interfaces #30

williamjacksn opened this issue Dec 7, 2018 · 1 comment · Fixed by #31
Labels
enhancement New feature or request

Comments

@williamjacksn
Copy link
Contributor

As far as I can tell, Excalibur listens on 127.0.0.1 and that can't be changed.

I am attempting to create a Docker container for Excalibur and I would like to have the web server listen on all interfaces to make it work.

I am not completely familiar with the code base, but I accomplished this myself by adding a "web_server_host" value to the [webserver] section of the config file, and changing the call to app.run() in cli.py:

app.run(host=conf.get('webserver', 'web_server_host'), use_reloader=False)

Is this a change you would be interested in adding to the project?

@vinayak-mehta
Copy link
Member

Yes, it would be awesome to add this, since it makes Excalibur more configurable! Would you be interested in submitting a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants