Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomicops.h on VS2015 #17

Closed
mintyc opened this issue Mar 31, 2015 · 3 comments
Closed

atomicops.h on VS2015 #17

mintyc opened this issue Mar 31, 2015 · 3 comments

Comments

@mintyc
Copy link

mintyc commented Mar 31, 2015

I notice that atomicops.h implements atomic_*_fence on all _MSC_VER

Is there any benefit to make this conditional on say _MSC_VER < 1900 as I think its all present and correct in <atomic> for VS2015

@cameron314
Copy link
Owner

Probably a good idea. It might take a little while before I get around to it, though.

@mintyc
Copy link
Author

mintyc commented Apr 1, 2015

I made the change but no significant difference to benchmark numbers (MSVS 2015 CTP 5)

Incidentally profile guided optimisation improves the folly scores by 10% but rest are unaffected

@cameron314
Copy link
Owner

Interesting, I never thought to try PGO.

I've committed the change (along with a blocking version of the queue) that uses the std:: fences on VS2012+. Thanks for opening this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants