Allow background position animation, support right/bottom positions, use inversion factor in calculations, allow repeated init of elements without ID attribute #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y conditions testing for negative are not necessary anymore
|
Good stuff. I'll test it out when I have a chance and merge it in. |
|
Found one issue already, doing another push soon... I'm actually trying to get background images to move too, just a bit of an issue with percentages as positioning, probably can't do that... |
…ts without an id attribute do not get registered again when their plax params are modified
… maintain position even in the event of resizes
|
16d0a96 makes sure that if the position is declared using right or bottom instead of left or top, those properties are used for positioning just in case the parent ever resizes and the positioning relative to the right or bottom of the parent should be maintained. 3f02a4a was the original point of my fiddling: moving stuff around via background-position :) |
|
Sorry I haven't merged this in yet. It's been a busy week. I'll give it a test and get it in there soon. |
|
No worries, take your time :) |
cameronmcefee
pushed a commit
that referenced
this pull request
Oct 31, 2011
Allow background position animation, support right/bottom positions, use inversion factor in calculations, allow repeated init of elements without ID attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag "background" can be set to animate background-position instead of element position (only allows pixel values, 0% and top/left, the rest is too complex/slow to compute due to how "100%" makes the background stick to the right/bottom of the container).
If the element was positioned using properties "right" or "bottom", then we make sure that those properties continue to be used for changing position.
ID attributes were used before to check if an element already is in the list of elements to work on, now compares DOM elements instead so no "id" attribute must exist.
Inversion factor cleans up the code a little :)