Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PLAX work properly with bottom: and right: attributes #22

Closed
fletom opened this issue Apr 20, 2012 · 4 comments
Closed

Make PLAX work properly with bottom: and right: attributes #22

fletom opened this issue Apr 20, 2012 · 4 comments

Comments

@fletom
Copy link

fletom commented Apr 20, 2012

Right now, PLAX doesn't handle these cases properly at all. There are lots of cases where bottom: and right: need to be used instead of top: and left:.

@cameronmcefee
Copy link
Owner

Can you cite some examples? Many of the recent updates have been directed at fixing bottom and right values.

@fletom
Copy link
Author

fletom commented Apr 20, 2012

Sure, but the easiest way I can think of showing you is on our staging server. Can you add me on jabber/Skype? (fletcher@nomulous.com / fletcher.tomalty)

@fletom
Copy link
Author

fletom commented Apr 20, 2012

Never mind about this. After playing around with it some more, I've figured out that it does seem to work, except that since for bottom: and right: a calculation has to be made, if PLAX is enabled before less.js finishes rendering our CSS, it calculates the wrong values. Still not sure how to fix it, but it isn't actually a problem with PLAX.

@cameronmcefee
Copy link
Owner

Ah, yeah. That would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants