Update to allow for editing to still occur if a rating prop is passed… #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in to enable behavior similar to 'defaultValue'. Requires editing prop to be passed in as true or it defaults to its previous behavior.
|
Great, thanks. 👍 |
|
Is this fixed now? I'm using 1.3.2, still, when the editing prop is set to true, and a rating prop is also set, it is not editable. |
|
I might be wrong about this but I don't think the changes were ever pushed On Tue, Oct 6, 2015 at 10:00 PM Jesse Wang notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in to enable behavior similar to 'defaultValue'. Requires editing prop to be passed in as true or it defaults to its previous behavior. #7