Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mandyBrigwell style is not dimension-less #74

Closed
camilleroux opened this issue Feb 20, 2022 · 6 comments
Closed

mandyBrigwell style is not dimension-less #74

camilleroux opened this issue Feb 20, 2022 · 6 comments

Comments

@camilleroux
Copy link
Owner

Hi @mandyBrigwell,

You're style is not currently dimension-less (same result whatever the size):
image
image

@camilleroux
Copy link
Owner Author

You should replace all the fxrand() by this._p5.random().
We can't reset the seed the fxrand() in our case

@mandyBrigwell
Copy link
Contributor

I've replaced it in my branch, but I'm not sure how to merge it with your branch. Give me a moment to do some googling…

@mandyBrigwell
Copy link
Contributor

Ah, got it—I was looking in the wrong place.

@mandyBrigwell
Copy link
Contributor

I think that does it now. I get the same for three test sizes.

02Appended

@mandyBrigwell
Copy link
Contributor

I've reworked the random code portion and pushed it. I'll let you decide whether to close this, as I don't want to be over-confident!

@camilleroux
Copy link
Owner Author

great! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants