Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unit test for LaboratoryController (LaboratoryControllerSpec) #38

Closed
camilosampedro opened this issue Oct 19, 2016 · 7 comments
Closed

Comments

@camilosampedro
Copy link
Owner

Create a unit test for controllers.LaboratoryController controller. It might be pretty similar to ComputerControllerSpec:

  • You would need to mock the dependencies of LaboratoryController (Add a return value to the needed methods without executing anything, they are not intended to be tested here).
  • Check the return HTTP code of the methods (Firstly as you would expect them to be).

Don't worry if you don't know something about the functionality of this class, it will be a pleasure to me to answer your questions.

@ubaldop
Copy link
Contributor

ubaldop commented Oct 21, 2016

@camilosampedro if you please I can go with this.

@camilosampedro
Copy link
Owner Author

Thank you very much @p3trur0, that would be very helpful.

I'm trying to create a good Angular frontend (To let it be more than static html), so I have not enough time to complete this.

I will create more issues for Aton, there is a lot to be done here! 😄

@ubaldop
Copy link
Contributor

ubaldop commented Oct 25, 2016

Cool! Did you consider React also?

Il ven 21 ott 2016, 20:57 Camilo A. Sampedro Restrepo <
notifications@github.com> ha scritto:

Thank you very much @p3trur0 https://github.com/P3trur0, that would be
very helpful.

I'm trying to create a good Angular frontend (To let it be more than
static html), so I have not enough time to complete this.

I will create more issues for Aton, there is a lot to be done here! 😄


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#38 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK8U7Ujo49rHkg5FQHnncpNrMVEE1Eh8ks5q2QsagaJpZM4Kbcx8
.

@camilosampedro
Copy link
Owner Author

camilosampedro commented Oct 25, 2016

No, I haven't checked it out. I also need to study Angular2 from the beginning, so which do you think is easier and better (For simple tasks)? Angular2 or React?

@ubaldop
Copy link
Contributor

ubaldop commented Oct 25, 2016

I have no experience with Angular 2, but React is really interesting and
I'd suggest to give it a try!

Il mar 25 ott 2016, 22:49 Camilo A. Sampedro Restrepo <
notifications@github.com> ha scritto:

No, I haven't checked it out. I also need to study Angular2 from the
beginning, so which do you think is easier? Angular2 or React?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#38 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK8U7dhKvQc-TfjJ6Qyn6fLlUMw-8_0rks5q3mtugaJpZM4Kbcx8
.

@camilosampedro
Copy link
Owner Author

The only needed thing is to not load the whole page, but update it when the server sends information. I will look for it, thank you as always, @p3trur0 !

@ubaldop ubaldop mentioned this issue Oct 28, 2016
@ubaldop
Copy link
Contributor

ubaldop commented Oct 28, 2016

@camilosampedro PR pushed here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants