HTML content opener

[randoum]

Add functionality to use HTML code for the open and close openers content by setting opener.as = 'html', allowing for example to use font-awesome icons by writing options like this :

    options =
      ...
      opener:
        active: true
        as: 'html'
        close: '<i class="fa fa-plus"></i>'
        open: '<i class="fa fa-minus"></i>'
        openerCss:
          'float': 'left'
          'margin-left': '-27px'
          'margin-top': '1px'
          'cursor': 'pointer'

    $('ul#hierarchy-tree').sortableLists options

[camohub]

Hi,
It is good idea. But make some refactoring please. Mainly use camelcase in fc and vars names. I did't check it properly yet. Give me a little time.
Have a nice day!

[camohub]

This should be enough
if ( setting.opener.as !== 'img' && setting.opener.as !== 'html' )
sholdn't be?

[randoum]

Done with your 2 feedbacks, let me know if there is more I can do

[camohub]

Hi I have it still on mind. But I am not 100% sure and have not enough time.

[randoum]

Ok noted.
Know that I use the patch every day and it work flawlessly.
Hope to see it merged soon :)
Cheers

[camohub]

We can leave it without as. Only if user want to switch to html he set it to "html". May be that param could be named as html: true,
Later in code(line 134) I would remove that condition. Next two conditions should be enough.

[camohub]

Now I see that if we leave it without as and you will check it you must do

If ( o.as && o.as === 'html' ) 

So there are two conditions but I would like to have one
Solution is to have as as default and check

if ( o.as ==== 'html' )

or param will be optional like asHtm: true and so condition will be

If ( o.asHtml ) 

I would like to have that last option.

[randoum]

Actually I used as 'img' and as 'html' in order to make it easy to add other modes in the future, someone may want to add a css class mode with as 'class'. What do you think?

[camohub]

For the future is important to have one place where you easy find and change this implementation. It solves setOpenClose() function. Conditions if ( html ) and if ( as === 'html' ) have the same efect. If you want to add cssClass if ( html ) will be false. No problem. Its easy to extend it in the future.

[camohub]

About that future. I think html will change current url and if you have html elements you can add class directly to them.

[camohub]

!!!!!! You are right with that opener[state] !!!!!!!! My head is out of order...

[camohub]

Thank you for good idea. I made it little different.