Remove clientX facts from solaris factsets
#167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are facts normally set by the puppet agent. https://puppet.com/docs/puppet/5.5/lang_facts_and_builtin_vars.html#puppet-agent-facts `clientversion`, `clientcert` have dedicated handling in rspec-puppet to set them correctly. https://github.com/rodjek/rspec-puppet/blob/f2e05f4a480a0d859121f5cab2dc5a70eb82d10a/lib/rspec-puppet/support.rb#L245 I found that the hardcoded values leads to a mismatch between the puppet version being tested and the value of `clientversion`. Specifically, it caused testing a module using concat with Puppet 5 to explode [here](https://github.com/puppetlabs/puppetlabs-concat/blob/b98de457a364908417b454f906a3ad5224bb04b9/manifests/fragment.pp#L47) (`Deferred` is not a valid type until Puppet 6).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are facts normally set by the puppet agent.
https://puppet.com/docs/puppet/5.5/lang_facts_and_builtin_vars.html#puppet-agent-facts
clientversion,clientcerthave dedicated handling in rspec-puppet toset them correctly.
https://github.com/rodjek/rspec-puppet/blob/f2e05f4a480a0d859121f5cab2dc5a70eb82d10a/lib/rspec-puppet/support.rb#L245
I found that the hardcoded values leads to a mismatch between the
puppet version being tested and the value of
clientversion.Specifically, it caused testing a module using concat with Puppet 5 to
explode here
(
Deferredis not a valid type until Puppet 6).These facts are not present in any other fact files.