ngeoDecorate*: two way binding ?

[fredj]

For now, the ngeoDecorate* services offer a one way binding (angular to ol3).
Is it planned to have a two way binding (ol3 to angular) ?

[elemoine]

Yes why not. Do you have a specific use-case in mind?

[fgravin]

We can do it with handling some ol events maybe, but take care of infinite loop !

[fredj]

Yes why not. Do you have a specific use-case in mind?

A ngeoDecorateView for example

[elemoine]

Yes why not. Do you have a specific use-case in mind?

A ngeoDecorateView for example

I was wondering about an application use-case.

Also, we could extend the ngeoDecorateGeolocation service to add a position property to the passed ol.Geolocation instance. This would also require binding in the other direction (ol3 -> angular).

I'd rather wait for specific use-cases before implementing this though, this is why I was asking if you had any.

[fredj]

I was wondering about an application use-case.

Display the view rotation in a text element:

<span>{{view.rotation}}</span>

[elemoine]

Ok.

Note that for view.center we'd need some debouncing, not to incur a digest cycle on each frame (when the map is panned or animates). We introduced an ngeoDebounce service that could be used there as well.

[elemoine]

@fredj, I guess making this work would just require triggering a digest cycle when the ol3 property changes. For example, this is what the ngeoDecorateLayer would do for the visible property:

    goog.events.listen(layer, ol.Object.getChangeEventType('visible'),
        /**
         * @type {ol.ObjectEvent} e Object event.
         */
        function(e) {
            $rootScope.$digest();
        }, false, this);

As I said, we'd need to be careful for the view center, because we don't want to trigger a digest every time the center changes while dragging the map.

What we could possibly do is add a boolean option/argument to the ngeoDecorate* functions.

[elemoine]

Closing this for now.