Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to remove the link to reset password #3202

Closed
rbovard opened this issue Dec 4, 2017 · 19 comments
Closed

How to remove the link to reset password #3202

rbovard opened this issue Dec 4, 2017 · 19 comments
Assignees
Milestone

Comments

@rbovard
Copy link
Contributor

rbovard commented Dec 4, 2017

  • GeoMapFish version: 2.1.11

What is the HTML attribute to remove the link to reset password? I think it should be something to set resetPasswordModalShown

Thanks.

@kalbermattenm
Copy link
Contributor

Are you looking for:

<gmf-authentication gmf-authentication-allow-password-change="false"></gmf-authentication>

?

@sbrunner sbrunner added this to the 2.2 milestone Dec 4, 2017
@rbovard
Copy link
Contributor Author

rbovard commented Dec 4, 2017

@kalbermattenm Thanks but where did you find it? I looked there https://camptocamp.github.io/ngeo/2.1/apidoc/gmf.authenticationDirective.html

@fredj
Copy link
Member

fredj commented Dec 4, 2017

This option is only available in ngeo >= 2.2:
https://camptocamp.github.io/ngeo/2.2/apidoc/gmf.authenticationDirective.html

@rbovard
Copy link
Contributor Author

rbovard commented Dec 4, 2017

Ouch... Any chance to backport it?

BTW: So I looked at the good place :)

@ybolognini
Copy link
Member

If this feature is a 2.2 feature then I think it should stay in 2.2.

Do you plan to migrate to 2.2?

@rbovard
Copy link
Contributor Author

rbovard commented Dec 4, 2017

The change of password or the ablitity to hide the the password change? Because with no SMTP, the error is brutal and it's impossible to hide it... See https://map.nyon.ch/mobile/

We just go live this weekend on 2.1, so now we're stabilizing the situation... And we are already confronted to this really annoying issue #3036, wich will not be fixed in 2.1 branch as discussed with @yjacolin

@rbovard
Copy link
Contributor Author

rbovard commented Dec 5, 2017

Any news on this one?

@rbovard
Copy link
Contributor Author

rbovard commented Dec 12, 2017

After upgrade to 2.2.1 it doesn't work with:

      <gmf-authentication id="login" class="gmf-mobile-nav-slide" data-header-title="{{'Login' | translate}}"
        gmf-mobile-nav-back="authCtrl.gmfUser.username !== null"
        gmf-authentication-allow-password-change="false">
      </gmf-authentication>

@kalbermattenm
Copy link
Contributor

You are right, I have the same problem and I am using the same option :
image

@rbovard
Copy link
Contributor Author

rbovard commented Dec 12, 2017

Thanks for the confirmation...

@rbovard
Copy link
Contributor Author

rbovard commented Dec 13, 2017

@fredj Did you plan to fix this issue?

@fredj
Copy link
Member

fredj commented Dec 13, 2017

@kalbermattenm gmf-authentication-allow-password-change="false" disable the "Change password" button when you're logged in, not the "Password forgotten?" when you're not already logged in.

@sbrunner sbrunner added the Ready label Dec 13, 2017
@rbovard
Copy link
Contributor Author

rbovard commented Dec 13, 2017

So it's not possible to disable the button to reset password??

@fredj
Copy link
Member

fredj commented Dec 13, 2017

@rbovard not for now

@kalbermattenm
Copy link
Contributor

@kalbermattenm gmf-authentication-allow-password-change="false" disable the "Change password" button when you're logged in, not the "Password forgotten?" when you're not already logged in.

Oh right... Sorry for the noise !

@rbovard
Copy link
Contributor Author

rbovard commented Dec 13, 2017

Nobody noticed it until today ;)

@kalbermattenm
Copy link
Contributor

Yeah... But @fredj has quite good eyes, these kind of "I do not miss a thing" eyes... 😃

@fredj
Copy link
Member

fredj commented Dec 14, 2017

fixed with #3262

@fredj fredj closed this as completed Dec 14, 2017
@rbovard
Copy link
Contributor Author

rbovard commented Jan 24, 2018

Thanks, it's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants