Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML code in attributes #965

Closed
rbovard opened this issue Mar 30, 2016 · 5 comments
Closed

HTML code in attributes #965

rbovard opened this issue Mar 30, 2016 · 5 comments
Assignees
Milestone

Comments

@rbovard
Copy link
Contributor

rbovard commented Mar 30, 2016

The HTML code in attributes is not interpreted on mobile.

Example:
<a href="https://github.com/" target="_blank">Cliquer ici</a>

@sbrunner sbrunner added this to the 2.0 milestone Mar 30, 2016
@tsauerwein
Copy link

@sbrunner Can the values in feature attributes always be trusted? Or can queries be made on user provided layers? In that case we would have to sanitize the values.

@sbrunner
Copy link
Member

sbrunner commented Apr 7, 2016

Good question, should we add a metatata with the list of the trsted (HTML) attributes?
For me it's better.

@tsauerwein
Copy link

... list of the trusted (HTML) attributes?

Would this be per layer or global? Global had the risk that a user-provided layer could have an attribute with the same name. Per layer, it would be sufficient to flag the whole layer as trusted (I think there would be no need to list each trusted attribute of a layer).

For now I would suggest to go with the sanitize-everything approach (see #996). If we see that this causes a problem, we can still introduce a trusted flag in the metadata.

@sbrunner
Copy link
Member

sbrunner commented Apr 7, 2016

Per layer, we don't have any global metadata

I think there would be no need to list each trusted attribute of a layer

It's exactly what I say :-)

can still introduce a trusted flag in the metadata.

List of attributes...

@tsauerwein
Copy link

Fixed with #996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants