Include list of all_changed_nodes in json report
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `puppet-catalog-diff-viewer` only looks at the nodes in `most_differences` to decide which nodes to display as 'with changes' and 'no changes'. By default, this list is limited to just 10 nodes with the most differences. Including a complete list of changed nodes in the json (regardless of `--changed_depth`) will make fixing puppet-catalog-diff-viewer much easier.
|
Very good idea (though it will require a similar change in the viewer)! |
alexjfisher
added a commit
to alexjfisher/puppet-catalog-diff-viewer
that referenced
this pull request
Oct 23, 2020
`all_changed_nodes` was added to the reports in voxpupuli/puppet-catalog_diff#34 This change doesn't start using it instead of `most_differences`, but does fix an issue with the string `all_changed_nodes` being mistaken for the name of a host with no changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
puppet-catalog-diff-vieweronly looks at the nodes inmost_differencesto decide which nodes to display as 'with changes'and 'no changes'. By default, this list is limited to just 10 nodes
with the most differences. Including a complete list of changed nodes
in the json (regardless of
--changed_depth) will make fixingpuppet-catalog-diff-viewer much easier.