Resource references do not accept a trailing comma

voxpupuli · Feb 18, 2015 · c4deada · c4deada
1 parent e932b66
commit c4deada
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 0 deletions.
diff --git a/lib/puppet-lint/plugins/check_trailing_comma.rb b/lib/puppet-lint/plugins/check_trailing_comma.rb
@@ -96,6 +96,9 @@ def check
 
     # Arrays
     array_indexes.each do |array|
+      # Do not check resource references
+      next if array[:tokens][0].prev_code_token && \
+        array[:tokens][0].prev_code_token.type == :CLASSREF
       check_elem(array, :LBRACK)
     end
 

diff --git a/spec/puppet-lint/plugins/check_trailing_comma/check_trailing_comma_spec.rb b/spec/puppet-lint/plugins/check_trailing_comma/check_trailing_comma_spec.rb
@@ -49,6 +49,12 @@ class { '::apache':
           },
           'qux' => 'ghi',
         }
+
+        service { 'bar':
+          subscribe => File[
+            '/etc/baz.conf', '/etc/baz.conf.d'
+             ],
+        }
         EOS
       }
 
@@ -102,6 +108,12 @@ class { '::apache':
           },
           'qux' => 'ghi'
         }
+
+        service { 'bar':
+          subscribe => File[
+            '/etc/baz.conf', '/etc/baz.conf.d'
+             ],
+        }
         EOS
       }
 
@@ -174,6 +186,12 @@ class { '::apache':
           },
           'qux' => 'ghi',
         }
+
+        service { 'bar':
+          subscribe => File[
+            '/etc/baz.conf', '/etc/baz.conf.d'
+             ],
+        }
         EOS
       }
 
@@ -231,6 +249,12 @@ class { '::apache':
           },
           'qux' => 'ghi'
         }
+
+        service { 'bar':
+          subscribe => File[
+            '/etc/baz.conf', '/etc/baz.conf.d'
+             ],
+        }
         EOS
       }
 
@@ -292,6 +316,12 @@ class { '::apache':
           },
           'qux' => 'ghi',
         }
+
+        service { 'bar':
+          subscribe => File[
+            '/etc/baz.conf', '/etc/baz.conf.d'
+             ],
+        }
           EOS
         )
       end