Change cert existance logic #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| subjectName = v if k == 'CN' | ||
| end | ||
|
|
||
| require File.expand_path('../../../../../../inifile/lib/puppet/util/ini_file', __FILE__) |
There was a problem hiding this comment.
Need to add ini_file as a requirement for this module for this to work. Also you shouldn't use the full path here because I can specify multiple directories for the module path to fulfill the ini_file requirement and this would fail. I think you can get away with just require 'puppet/util/ini_file' if it is available
There was a problem hiding this comment.
Yeah, of course. Also tests should be touched a little. To every thing there is a season, you know :)
openstack-gerrit
pushed a commit
to openstack-archive/fuel-library
that referenced
this pull request
Sep 2, 2015
Add checking commonName and subjectAltName in old certificate if it exists. In other way we could not regenerate a new certificate if any of these fields change. Closes-Bug: #1490966 Upstream pull-request: voxpupuli/puppet-openssl#51 Change-Id: I1375a9d1ce5f50e84edee4ecc21614450408ae73
sorrowless
force-pushed
the
fix_cert_regeneration
branch
from
079dcc2
to
7f86e8f
Compare
sorrowless
force-pushed
the
fix_cert_regeneration
branch
from
7f86e8f
to
3558925
Compare
Add checking commonName and subjectAltName in old certificate if it exists. In other way we could not regenerate a new certificate if any of these fields change.
sorrowless
force-pushed
the
fix_cert_regeneration
branch
from
3558925
to
e29608f
Compare
openstack-gerrit
pushed a commit
to openstack-archive/fuel-library
that referenced
this pull request
Oct 9, 2015
This commit removes 'openssl' module from fuel-library and replaces it to be managed via librarian. This commit uses custom 1.3.10-mos-rc2 tag of openssl module because it contains 3 custom patches, which aren't merged in upstream yet: https://review.fuel-infra.org/#/c/11545/ - isn't in 1.3.0 version https://review.fuel-infra.org/#/c/11546/ and https://review.fuel-infra.org/#/c/12263/ are part of one upstream pull request: voxpupuli/puppet-openssl#51 When #51 pull request will be merged in upstream we will switch on latest upstream tag of openssl module. Partial implements: blueprint fuel-puppet-librarian Change-Id: I58c271582e6028c69e7b976ddc7f552e9e497d61
|
I like the idea in this PR, but I think I'd rather associate a new |
|
I'm not sure ensure => synced makes sense. This just adds a check on the name to make sure the cert has correct values, why would we want to hide this only to occur if you use ensure => synced? That's not a standard puppet pattern is it? |
teran
pushed a commit
to fuel-infra/puppet-openssl
that referenced
this pull request
Jan 20, 2016
Add checking commonName and subjectAltName in old certificate if it exists. In other way we could not regenerate a new certificate if any of these fields change. Closes-Bug: #1490966 Upstream pull-request: voxpupuli/puppet-openssl#51 Change-Id: I1375a9d1ce5f50e84edee4ecc21614450408ae73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checking commonName and subjectAltName in old certificate
if it exists. In other way we could not regenerate a new certificate
if any of these fields change.