Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to upstream default for mydestination #256

Merged
merged 1 commit into from May 13, 2023
Merged

Switch to upstream default for mydestination #256

merged 1 commit into from May 13, 2023

Conversation

kenyon
Copy link
Member

@kenyon kenyon commented Jul 29, 2019

It is less surprising if the puppet module's default configuration matches a standard default postfix configuration.

@raphink
Copy link
Member

raphink commented Aug 15, 2019

I understand the idea, but I'm not really keen on changing defaults. You can easily change that value in hiera with postfix::mydestination in your common data file.

@kenyon
Copy link
Member Author

kenyon commented Aug 15, 2019

Why would the module defaults be different from standard Postfix defaults though? That’s a bit weird.

@kenyon
Copy link
Member Author

kenyon commented Aug 15, 2019

In this particular case, not having localhost in $mydestination breaks delivery of most system-generated mail going to root@localhost.

@stale
Copy link

stale bot commented Apr 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 19, 2021
@gcoxmoz
Copy link
Contributor

gcoxmoz commented Apr 19, 2021

Obligatory comment to keep this alive. stale-bot is gross.

@stale stale bot removed the wontfix label Apr 19, 2021
ghoneycutt
ghoneycutt approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@ghoneycutt ghoneycutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for merging this whenever the next major release is getting ready to be merged. It is very easily worked around by supplying different data, so no use in doing a major bump just for this.

@kenyon
Copy link
Member Author

kenyon commented Jan 12, 2023

I missed this in release 3.0.0 #331 :(

@bastelfreak bastelfreak removed the enhancement New feature or request label Jan 12, 2023
@smortex smortex mentioned this pull request Mar 1, 2023
Merged
@smortex
Copy link
Member

smortex commented May 13, 2023 •
edited

A breaking release was merged to remove Puppet 6 (#351). Let's not miss the opportunity again and merge this!

@smortex smortex merged commit 77707e2 into voxpupuli:master May 13, 2023
@smortex smortex changed the title init.pp: use the postfix default for mydestination Switch to upstream default for mydestination May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

@ghoneycutt ghoneycutt ghoneycutt approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

@mcanevet mcanevet Awaiting requested review from mcanevet

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kenyon @raphink @gcoxmoz @smortex @ghoneycutt @bastelfreak