Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES6 Array.from #206

Closed
wizardforcel opened this issue Nov 23, 2018 · 0 comments · Fixed by #218
Closed

ES6 Array.from #206

wizardforcel opened this issue Nov 23, 2018 · 0 comments · Fixed by #218

Comments

@wizardforcel
Copy link 

Array.prototype.xxx.call(document.querySelectorAll(selector), args)

==>

Array.from(document.querySelectorAll(selector)).xxx(args)
@camsong camsong closed this as completed in 91aa934 Apr 1, 2019
camsong added a commit that referenced this issue Apr 1, 2019
@camsong
prefer Array.from to Array.prototype.xxx.call, close #206
9692c6e
moshihuang added a commit to moshihuang/You-Dont-Need-jQuery that referenced this issue Apr 8, 2019
@moshihuang
Update README.zh-TW.md
f23013c 
. update zh-TW content according to commit 9692c6e - "prefer Array.from to Array.prototype.xxx.call, close camsong#206"
. translate comments
@moshihuang moshihuang mentioned this issue Apr 8, 2019
Merged
jsEveryDay pushed a commit to jsEveryDay/You-Dont-Need-jQuery that referenced this issue Apr 19, 2019
@camsong @jsEveryDay
prefer Array.from to Array.prototype.xxx.call, close camsong#206
0ee897b
jsEveryDay pushed a commit to jsEveryDay/You-Dont-Need-jQuery that referenced this issue Apr 19, 2019
@moshihuang @jsEveryDay
Update README.zh-TW.md
ef1d7f8 
. update zh-TW content according to commit 9692c6e - "prefer Array.from to Array.prototype.xxx.call, close camsong#206"
. translate comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update README.zh-TW.md moshihuang/You-Dont-Need-jQuery
1 participant
@wizardforcel