Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest pgns.xml missing 'Type' for some fields #389

Closed
sbender9 opened this issue Mar 24, 2023 · 2 comments · Fixed by #392
Closed

Latest pgns.xml missing 'Type' for some fields #389

sbender9 opened this issue Mar 24, 2023 · 2 comments · Fixed by #392
Assignees
Labels

Comments

@sbender9
Copy link
Member

sbender9 commented Mar 24, 2023

Sorry, I tried to figure out why, but no luck...

Date and Time Type missing here. Might be others types too, tons of stuff broken in canboatjs with latest pgns.json.

DEBUG 2023-03-24T21:10:04.713Z [analyzer-explain] PGN 129033 len=8
      <Length>8</Length>
      <Fields>
        <Field>
          <Order>1</Order>
          <Id>date</Id>
          <Name>Date</Name>
          <BitLength>16</BitLength>
          <BitOffset>0</BitOffset>
          <BitStart>0</BitStart>
          <Units>d</Units>
          <Resolution>1</Resolution>
          <Signed>false</Signed>
          <RangeMin>0</RangeMin>
          <RangeMax>65533</RangeMax>
        </Field>
        <Field>
          <Order>2</Order>
          <Id>time</Id>
          <Name>Time</Name>
          <Description>Seconds since midnight</Description>
          <BitLength>32</BitLength>
          <BitOffset>16</BitOffset>
          <BitStart>0</BitStart>
          <Units>s</Units>
          <Resolution>0.0001</Resolution>
          <Signed>false</Signed>
          <RangeMin>0</RangeMin>
          <RangeMax>86402</RangeMax>
        </Field>
@keesverruijt keesverruijt self-assigned this Mar 24, 2023
@keesverruijt
Copy link
Collaborator

Let’s add a test so this can’t happen again.

@sbender9
Copy link
Member Author

Also "Discrete Status 1" missing type for pgn 127489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants