Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Adapter Specific Code #15

Closed
bryanrite opened this issue Mar 9, 2014 · 1 comment
Closed

Extract Adapter Specific Code #15

bryanrite opened this issue Mar 9, 2014 · 1 comment
Assignees
@bryanrite
Labels
bug

Comments

@bryanrite
Copy link
Member

In lib/cancan/rule.rb:114, there is ActiveRecord specific code which should really be in a adapter. The context of the code is too complex to refactor it into the adapter though... so that whole method needs to be broken down as well.

As discovered in #13 ... I guarded it so that datamapper and mongoid would work as a temporary solution.
@coorasse
Copy link
Member

is this still a valid issue? would you send a PR eventually? Otherwise can be closed. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryanrite bryanrite

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bryanrite @coorasse