[BUG] undefined method define' for RSpec::Matchers:Module`

[JustinAiken]

Upon this line in my spec_helper:

require 'cancan/matchers'

I get this:

/Users/jaiken/.rvm/gems/ruby-2.0.0-p247@pws/gems/cancancan-1.7.0/lib/cancan/matchers.rb:2:in `<top (required)>': undefined method `define' for RSpec::Matchers:Module (NoMethodError)
    from /Users/jaiken/.rvm/gems/ruby-2.0.0-p247@pws/gems/activesupport-3.2.17/lib/active_support/dependencies.rb:251:in `require'
    from /Users/jaiken/.rvm/gems/ruby-2.0.0-p247@pws/gems/activesupport-3.2.17/lib/active_support/dependencies.rb:251:in `block in require'
    from /Users/jaiken/.rvm/gems/ruby-2.0.0-p247@pws/gems/activesupport-3.2.17/lib/active_support/dependencies.rb:236:in `load_dependency'
    from /Users/jaiken/.rvm/gems/ruby-2.0.0-p247@pws/gems/activesupport-3.2.17/lib/active_support/dependencies.rb:251:in `require'
    from /Users/jaiken/projects/phrg/pws/spec/spec_helper.rb:12:in `<top (required)>'
    from /Users/jaiken/projects/phrg/pws/spec/models/agent_originator_spec.rb:1:in `require'
    from /Users/jaiken/projects/phrg/pws/spec/models/agent_originator_spec.rb:1:in `<top (required)>'
    from /Users/jaiken/.rvm/gems/ruby-2.0.0-p247@pws/gems/rspec-core-2.14.8/lib/rspec/core/configuration.rb:896:in `load'
    from /Users/jaiken/.rvm/gems/ruby-2.0.0-p247@pws/gems/rspec-core-2.14.8/lib/rspec/core/configuration.rb:896:in `block in load_spec_files'
    from /Users/jaiken/.rvm/gems/ruby-2.0.0-p247@pws/gems/rspec-core-2.14.8/lib/rspec/core/configuration.rb:896:in `each'
    from /Users/jaiken/.rvm/gems/ruby-2.0.0-p247@pws/gems/rspec-core-2.14.8/lib/rspec/core/configuration.rb:896:in `load_spec_files'
    from /Users/jaiken/.rvm/gems/ruby-2.0.0-p247@pws/gems/rspec-core-2.14.8/lib/rspec/core/command_line.rb:22:in `run'
    from /Users/jaiken/.rvm/gems/ruby-2.0.0-p247@pws/gems/rspec-core-2.14.8/lib/rspec/core/runner.rb:80:in `run'
    from /Users/jaiken/.rvm/gems/ruby-2.0.0-p247@pws/gems/rspec-core-2.14.8/lib/rspec/core/runner.rb:17:in `block in autorun'

cancancan 1.70
Rails 3.2.17
Rspec 2.14.1

[JustinAiken]

This doesn't happen with Rspec 2.13 - something changed between 2.13 and 2.14 that changed this.

If I just add require 'rspec/expectations' to the top of lib/cancan/matchers.rb, it works okay. Not sure if that would break compatibility with other versions of rspec though. Also works if I add that line to my own spec_helper before I require cancan.

[bryanrite]

This is on master or 1.7.0?

[bryanrite]

bah.. obviously the 1.7.0... sorry... i'll check it out.

[bryanrite]

Upon some investigation:

https://github.com/rspec/rspec/commit/15ef280ac74b03f612d6038f484d80226fb38e03

Removed explicitly requiring both expectations and mocks. So it should be fixable by:

Removing

require 'rspec'

and adding

require 'rspec/core'
require 'rspec/expectations'
require 'rspec/mocks'

I'll get this in asap as a patch release.

[bryanrite]

@JustinAiken I haven't actually been able to duplicate your issue, no matter where I require cancan/matches ... Could you try running against:

https://github.com/CanCanCommunity/cancancan/tree/feature/fix_rspec

And let me know if that fixes it, either that or paste a minimal spec_helper. Super appreciated!

[bryanrite]

@JustinAiken ping?

[JustinAiken]

Oh, haha... I was bundleing up that ref as you pinged me :)

Yes confirmed - that fixes it :)

[bryanrite]

hahaha... great thanks, I'll push a 1.7.1 release today.

[JustinAiken]

Also, this probably isn't needed since that PR fixes it, but for future reference, in case anybody has issues in the future and googles this:

My spec_helper started with:

require File.dirname(__FILE__) + "/../config/environment" unless defined?(Rails.root)

require 'shoulda'
require 'cancan/matchers'
require 'rspec/rails'
require 'timecop'
require 'webmock/rspec'

...and before this PR, failed unless I added require 'rspec/expectations' right before requireing cancan's matchers - with this PR my spec_helper remains as is.