Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move isolation_level to the root of a sqlalchemy data source configuration #447

Closed
piraz opened this issue Apr 21, 2024 · 0 comments
Closed
Assignees

Comments

@piraz
Copy link
Contributor

piraz commented Apr 21, 2024

The isolation level use to be in the pool configuration of a sqlalchemy data source. Let's move it to the root.

Instead of:

data:
  sources:
    - name: test
      connector: sqlalchemy
      url: mysql+pymysql://root@localhost:3306/test
      pool:
        - isolation_level: REPEATABLE READ

Place it at:

data:
  sources:
    - name: test
      connector: sqlalchemy
      url: mysql+pymysql://root@localhost:3306/test
      isolation_level: REPEATABLE READ
@piraz piraz added this to the firenado 0.9.5 milestone Apr 21, 2024
@piraz piraz self-assigned this Apr 21, 2024
@piraz piraz closed this as completed in 0bc6560 Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant