add optional profile parameter #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candid-elliott
previously approved these changes
Feb 28, 2020
vagelim
commented
Feb 28, 2020
| @@ -12,8 +12,8 @@ | |||
|
|
|||
|
|
|||
| class SecretsManager: | |||
| def __init__(self, secrets_file=None, secrets_file_default=None, region_name=None): | |||
| session = boto3.session.Session() | |||
There was a problem hiding this comment.
Aside, but I had thought of moving the region parameter to the session instantiation but didn't want to change too much.
dvf
previously approved these changes
Feb 28, 2020
dvf
previously approved these changes
Feb 28, 2020
dvf
reviewed
Feb 28, 2020
confidential/__init__.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| from confidential.secrets_manager import SecretsManager | |||
|
|
|||
| __all__ = ["SecretsManager"] | |||
| __version__ = "1.0.0" | |||
| __version__ = "1.1.0" | |||
There was a problem hiding this comment.
We initially were using this to store the version, but the version is now stored by Poetry in pyproject.toml. So we move this, and you'll need to bump the version in pyproject.toml.
this is the wrong place to increment version
vagelim
force-pushed
the
feature/add-profile-param
branch
from
6d2b6a0
to
7e07220
Compare
dvf
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds an optional parameter (
-p,--profile) to allow the user to pass in an alternative profile.Why did you do this?
The current configuration limits confidential to the default profile. For users with multiple profiles, they may wish to use confidential with something beyond the default profile.
How did you test this change?
Ran with a known working profile, with a known non-working profile, with a profile that doesn't exist, and lastly, with no profile specified at all.
etc
I had thought of catching the exception raised when a profile is specified but could not be found (
botocore.exceptions.ProfileNotFound) but found the error message to be descriptive enough on its own.ex: