Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'android.os.AsyncTask' is deprecated #9

Closed
Prabha10cs opened this issue Dec 3, 2020 · 13 comments · Fixed by #25
Closed

'android.os.AsyncTask' is deprecated #9

Prabha10cs opened this issue Dec 3, 2020 · 13 comments · Fixed by #25
Assignees
Milestone

Comments

@Prabha10cs
Copy link

No description provided.

@Canato
Copy link
Member

Canato commented Dec 3, 2020

indeed, hopefully we can update this soon

@Canato
Copy link
Member

Canato commented Dec 28, 2020

Just to be clear with who will help. Let's use Coroutines

@SanjayDevTech
Copy link
Contributor

@Canato Can I work on this issue? Could you assign it to me?

@Canato
Copy link
Member

Canato commented Jan 5, 2021

Yes @SanjayDevTech will add you to the team, so I can assign to you, please keep us update ^^

@Canato Canato assigned Canato and SanjayDevTech and unassigned Canato Jan 5, 2021
@Canato Canato added this to the v_1.2.0 milestone Jan 5, 2021
@SanjayDevTech
Copy link
Contributor

@Canato sure... I will commit the changes to my forked repository...

@Canato
Copy link
Member

Canato commented Jan 5, 2021

@SanjayDevTech please use Coroutines as much you can =)

@SanjayDevTech
Copy link
Contributor

This is my plan @Canato :

  1. Migrate some code to Kotlin (Just to implement Coroutine)
  2. Replace AsyncTask with Coroutines
  3. Refactoring CropImageView to use new Coroutine class 😃

@Canato
Copy link
Member

Canato commented Jan 5, 2021

This is my plan @Canato :

  1. Migrate some code to Kotlin (Just to implement Coroutine)
  2. Replace AsyncTask with Coroutines
  3. Refactoring CropImageView to use new Coroutine class 😃

Perfect! can we do this in 3 PRs to make faster to review?

@SanjayDevTech
Copy link
Contributor

@Canato I have done 50% of migration
It is saying me to wait for your approval

@Canato
Copy link
Member

Canato commented Jan 5, 2021

@SanjayDevTech Please open a PR so I can review and approve

@SanjayDevTech
Copy link
Contributor

@Canato Opened : )

@SanjayDevTech
Copy link
Contributor

@Canato Final PR is opened : )

@SanjayDevTech
Copy link
Contributor

@Canato ChangeLog and Readme updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants