Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

behavior signatures are inconsistent #171

Closed
marshallswain opened this issue Oct 29, 2016 · 2 comments
Closed

behavior signatures are inconsistent #171

marshallswain opened this issue Oct 29, 2016 · 2 comments
Assignees
@phillipskevin
Labels
bug p2

Comments

@marshallswain
Copy link
Member

The arg name is inconsistent. On some it's baseConnect. Others have baseConnection. And even others have baseBehavior.

screen shot 2016-10-29 at 12 38 56 am
screen shot 2016-10-29 at 12 38 40 am
screen shot 2016-10-29 at 12 38 30 am
screen shot 2016-10-29 at 12 40 26 am
@phillipskevin
Copy link
Contributor

@justinbmeyer I can pick this up. I think baseBehavior makes the most sense. Do you have a preference?

@phillipskevin phillipskevin self-assigned this Nov 16, 2016
@phillipskevin
Copy link
Contributor

Actually, I'm going to go with baseConnection since that is what most of the docs use (outside of the signature).

@phillipskevin phillipskevin mentioned this issue Nov 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillipskevin phillipskevin

Labels
bug p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justinbmeyer @marshallswain @phillipskevin