New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.splice(list, 5,1) inserts undefined #112

Closed

justinbmeyer opened this issue May 30, 2018 · 0 comments · Fixed by #114

Labels

easy

Contributor

justinbmeyer commented May 30, 2018 •

edited

If the 4rd argument is not provided, it still tries to insert an item.

var arr = ["a","b"];
canReflect.splice(arr, 0, 1);

arr //-> should be ["b"], but is [undefined, "b"]

justinbmeyer added the easy label

Aosanders mentioned this issue

splice fix training #114

Merged

justinbmeyer closed this as completed in #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment