Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of keepHash. #133

Open
indifferentghost opened this issue Dec 3, 2018 · 0 comments
Open

Removal of keepHash. #133

indifferentghost opened this issue Dec 3, 2018 · 0 comments
Labels
cleanup easy semver major

Comments

@indifferentghost
Copy link
Contributor

this.keepHash was added in response to #95, to make keepHash default to true.
The same functionality was previously with includeHash, which defaulted to false: d8fdbf1.

I believe this.keepHash can be removed.

  • There is no documentation pointing to the use of this.keepHash as a feature.
  • At the moment there's never a time it's not true. We always want to keep the hash when setting the URL.
@indifferentghost indifferentghost changed the title Removal of this.keepHash. Removal of keepHash. Dec 3, 2018
@indifferentghost indifferentghost mentioned this issue Dec 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup easy semver major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chasenlehara @indifferentghost