Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on:click style events create viewmodels on elements #540

Closed
phillipskevin opened this issue Jul 16, 2019 · 0 comments · Fixed by #541
Closed

on:click style events create viewmodels on elements #540

phillipskevin opened this issue Jul 16, 2019 · 0 comments · Fixed by #541

Comments

@phillipskevin
Copy link
Contributor

Events like on:click will create a viewModel when the event happens because can-view-model is being called here:

can-stache-bindings/can-stache-bindings.js

Line 554 in b214428

var viewModel = canViewModel(el);

This should check the Symbol instead so that extra SimpleMaps are not created as the viewmodel for normal DOM elements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@phillipskevin