Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into where we can improve performance #244

Open
andrejewski opened this issue Jul 17, 2017 · 1 comment
Open

Look into where we can improve performance #244

andrejewski opened this issue Jul 17, 2017 · 1 comment
Assignees

Comments

@andrejewski
Copy link
Contributor

andrejewski commented Jul 17, 2017

@chasenlehara commented on Fri Jul 14 2017:

In today’s contributors meeting, we talked about how the performance improvements to can-stache with can-reflect weren’t as good as the initial prototypes. This issue is for looking into what we can do to make things faster.

@phillipskevin
Copy link
Contributor

Leaving some info here for when we revisit this, I found that we are calling Observation.add a lot more than we were in 3.8.0:

(3.8.0 on the left, latest master on the right)
image

The count shown at the bottom is the total # of times Observation.add is called.

@phillipskevin phillipskevin mentioned this issue Oct 6, 2017
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants