Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makeWindow should also set self #5

Open
matthewp opened this issue Oct 17, 2016 · 1 comment
Open

makeWindow should also set self #5

matthewp opened this issue Oct 17, 2016 · 1 comment
Labels
bug

Comments

@matthewp
Copy link
Contributor

In modern browsers self is the global for both the window and the web worker global. Browserify UMD sets self when it detects it is running in a browser. Since we are faking running in a browser we should shim that as well.
@matthewp matthewp added the bug label Oct 17, 2016
@matthewp matthewp self-assigned this Oct 17, 2016
@matthewp
Copy link
Contributor Author

Originally filed in stealjs/steal#862

@matthewp matthewp mentioned this issue Oct 17, 2016
Closed
@matthewp matthewp removed their assignment Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthewp