New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversions architecture overhaul #87

Closed

cannawen opened this issue Oct 10, 2017 · 0 comments · Fixed by #114

Labels

Owner

cannawen commented Oct 10, 2017 •

edited

Loading

Similar to #28, our conversions file is getting out of hand. Consider refactoring so that each conversion's data is in a .yaml file

Consider using the regex length to sort the order of conversions, so "miles per hour" (14 char) will get triggered before "miles" (5 char).

Maybe we should stop adding new conversions, until this refactor is in place?

This issue is open for discussion on reddit

cannawen added the discussion label

Repository owner locked and limited conversation to collaborators

cannawen closed this as completed in #114

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.