Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #24: update tokio #25

Merged
merged 5 commits into from May 8, 2019
Merged

Conversation

povilasb
Copy link
Collaborator

@povilasb povilasb commented May 2, 2019

Adopted netsim code to latest tokio API changes.

canndrew and others added 4 commits April 30, 2019 13:44
Make sure Network is not dropped before we actually finish running our final future.
Before Network object was moved into future::lazy() closure which would then
drop the Network before we actually we finished which resulting in panicking.
@povilasb
Copy link
Collaborator Author

povilasb commented May 2, 2019

One test occasionally fails

test node::ether::machine::test::one_interface_send_udp_ipv4 ... FAILED

thread '<unnamed>' panicked at 'unexpected payload: Unknown { ethertype: 34525, payload: b"`\0\0\0\0$\0\x01\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\xff\x02\0\0\0\0\0\0\0\0\0\0\0\0\0\x16:\0\x05\x02\0\0\x01\0\x8f\0\x02d\0\0\0\x01\x04\0\0\0\xff\x02\0\0\0\0\0\0\0\0\0\x01\xff\x1cm\n" }', src/node/ether/machine.rs:127:36

But it does sometimes fail on master branch (a768a11) as well.

@povilasb povilasb changed the title Update tokio resolves #24: update tokio May 2, 2019
@canndrew
Copy link
Owner

canndrew commented May 7, 2019

Awesome man. Good job :D

@canndrew canndrew merged commit bb1fc7d into canndrew:master May 8, 2019
This was referenced May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants