Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table is not getting selected after searching for second time #396

Open
himanshu634 opened this issue Jun 11, 2024 · 3 comments
Open

Table is not getting selected after searching for second time #396

himanshu634 opened this issue Jun 11, 2024 · 3 comments
Labels
bug Something isn't working contribution-welcome module/ui UI related

Comments

@himanshu634
Copy link
Contributor

I was trying to select multiple tables from the search input box. I selected one table and then searched for another table and tried to select it but the first one was getting deselected.

To Reproduce
Steps to reproduce the behavior:

  1. Connect To DB.
  2. Select the table.
  3. Select another table after searching it.
  4. The first one will get deselected.

Expected behavior
Both tables should be selected.

Screenrecording
Video is here.
@himanshu634 himanshu634 added the bug Something isn't working label Jun 11, 2024
@andreashimin
Copy link
Contributor

Thank you for reporting this issue.

The first table got deselected because the search input filters out the selected table. For now, you will need to clear the search input to restore the selected table before submitting.

I will discuss this problem with the team to find a fix.

@himanshu634
Copy link
Contributor Author

himanshu634 commented Jun 12, 2024 •
edited
Loading

Can I work on this issue?

@andreashimin
Copy link
Contributor

Sure, your contribution would be very welcome, I can help you review the PR.

@fredalai fredalai added the module/ui UI related label Jun 14, 2024
andreashimin pushed a commit that referenced this issue Jul 10, 2024
@himanshu634
Multiple table selection enabled after search. #396 (#491)
3a4d429 
* fix: multiple table selection enabled after search

* fix: removed console statements

* fix: added  select all functionality

* fix: select all issue fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working contribution-welcome module/ui UI related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andreashimin @onlyjackfrost @fredalai @himanshu634