Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Shader Combination #51

Closed
cannontwo opened this issue Nov 18, 2020 · 3 comments
Closed

Implement Shader Combination #51

cannontwo opened this issue Nov 18, 2020 · 3 comments
Assignees
@cannontwo
Labels
enhancement New feature or request graphics

Comments

@cannontwo
Copy link
Owner

Essentially, the VertexShader and FragmentShader classes should have a constructor which takes multiple filenames or multiple strings containing shader code and combine them into a single shader.

Note that only one of the strings/files to be combined should include a main function, as otherwise compilation will fail.
@cannontwo cannontwo added enhancement New feature or request graphics labels Nov 18, 2020
@cannontwo cannontwo self-assigned this Nov 18, 2020
@cannontwo
Copy link
Owner Author

As an addendum, also implement basic #include preprocessing in the shader source itself.

@cannontwo cannontwo mentioned this issue Nov 18, 2020
Closed
@cannontwo
Copy link
Owner Author

#52 depends on this.

@cannontwo
Copy link
Owner Author

Resolved by a369c8d. Delaying handling "#include" for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cannontwo cannontwo

Labels
enhancement New feature or request graphics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cannontwo