Updates build_get_articles_url to use urllib.parse.urlencode #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nottrobin
reviewed
Jun 18, 2019
nottrobin
reviewed
Jun 18, 2019
nottrobin
reviewed
Jun 18, 2019
tbille
reviewed
Jun 19, 2019
nottrobin
reviewed
Jun 19, 2019
nottrobin
reviewed
Jun 19, 2019
nottrobin
reviewed
Jun 19, 2019
nottrobin
reviewed
Jun 19, 2019
|
|
||
| return url | ||
| clean_params = {} | ||
| for key, value in params.items(): |
…moving get_articles_with_metadata and only have a single function that returns metadata in addition to normal payload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Fixes #15
Uses
urllib.parse.urlencodeinbuild_get_articles_urlQA
Working tests reflect that the application still behaves normally