New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SVG topology to bundles #775
Add SVG topology to bundles #775
Conversation
Demo starting at https://charmhub-io-775.demos.haus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just add the topology to the template above the readme? It will give you more freedom to mark it up and its where the next developer will first look to find it.
Does the design ask for it to be injected into the readme?
9bc4318
to
b786ce8
Compare
@danielmutis said that he wants the title to come first as per the design. @danielmutis what do you think? |
The main title of the page is the bundle name on the header. As a developer I would expect to see my readme not modified with injected image. It seems more natural to have before the readme to get a quick understanding of the bundle. It also removes a code complexity, and we like simple code 😆 |
@solazio Let's push the whole readme below the image then. @tbille @anthonydillon my main worry about the image is that it pushes the content down by a lot because they are quite large. I wonder if maybe we should hide part of it and have a show more. |
b786ce8
to
b62103b
Compare
You could put the topology in its own tab? |
b62103b
to
6537728
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @solazio, few comments inline.
6537728
to
fb14ddd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Done
How to QA
$ dotrun
and view it in your web browser at: http://localhost:8045/kubeflowIssue / Card
Fixes #
Screenshots