New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add animations to the configuration UI #844
Conversation
…here is no config.
Demo starting at https://jaas-dashboard-844.demos.haus |
Thanks for looking at this @hatched, a couple of things I noticed...
Perhaps unrelated to this PR...
|
@hatched can you adjust the motion duration. It seems a little slow leading to a laggy feel. Maybe try halving the default. We have some standard durations here: https://vanillaframework.io/docs/settings/animation-settings |
These animations are all using the defined Vanilla speeds, they are all set to
This is it working correctly. If the configuration value has been changed from the default already then these will already be there when you view the config.
Yes this is a limitation of how React works - We can come up with a resolution but after doing it as a hack I found that the snap to other description felt better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, few comments in the code but no blockers
Thanks for the reviews! |
Done
Add animations and fades to give the config some life.
Blocked on #843 landing, once it's landed then this can be reviewed and qa'd
QA
Details
https://github.com/canonical-web-and-design/juju-squad/issues/1601