Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move run script to root. #9

Merged
merged 3 commits into from Jun 11, 2019
Merged

Conversation

squidsoup
Copy link
Contributor

@squidsoup squidsoup commented Jun 11, 2019

Adding support to the demoservice for monorepos is potentially complex, so as a compromise we'll move run to the root, and selectively point at an individual workspace project. Currently the serve' target in package.jsonwill point to theui` workspace, but later will point to the single-spa root project once that is implemented. This does mean we will not have demos for the legacy maas frontend when it is migrated to this repo, but I think we can live with that given it has never had demos.

QA

Run run from the project root. It should spin up the ui app on http://localhost:8000

@webteam-app
Copy link

Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a clean target too. This should remove all deps and builds.

@huwshimi
Copy link
Contributor

huwshimi commented Jun 11, 2019

I've added https://github.com/canonical-web-and-design/MAAS-squad/issues/1236 for adding the clean.

Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

@anthonydillon anthonydillon self-assigned this Jun 11, 2019
@squidsoup squidsoup merged commit fb319e3 into canonical:master Jun 11, 2019
@squidsoup squidsoup deleted the move-run-root branch June 11, 2019 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants