Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cronjob #15

Merged
merged 1 commit into from Jul 2, 2021
Merged

Fix cronjob #15

merged 1 commit into from Jul 2, 2021

Conversation

jkfran
Copy link
Contributor

@jkfran jkfran commented Jul 2, 2021

Done

  • There are some snaps breaking this step of the cronjob. We need the cronjob to be back working before the next Marketo email.

QA

  1. Pull the branch
  2. Ask for the .env.local file secrets
  3. Docker build: docker build . --tag test
  4. Docker run: docker run -ti --env-file .env.local test

steverydz
steverydz approved these changes Jul 2, 2021
View reviewed changes
Copy link

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jkfran jkfran merged commit 8097d28 into canonical:master Jul 2, 2021
@jkfran jkfran deleted the skip-snaps branch July 2, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverydz steverydz steverydz approved these changes

Assignees
No one assigned
Labels
Review: Code +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkfran @steverydz