Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save/Revert are not disabled for snap with categories #1776

Closed
bartaz opened this issue Apr 4, 2019 · 0 comments · Fixed by #2404
Closed

Save/Revert are not disabled for snap with categories #1776

bartaz opened this issue Apr 4, 2019 · 0 comments · Fixed by #2404

Comments

@bartaz
Copy link
Contributor

bartaz commented Apr 4, 2019

Found when testing #1772

Steps to reproduce the problem

  1. Go to listing page of a snap with category set
  2. Change anything on listing page (add something to title)
  3. Save/Revert button should get enabled
  4. Without saving anything remove the change done before (change the title back)
  5. Save/Revert button should get disabled (there are no changes to save), but doesn't

Expected behaviour

Save/Revert button should get properly disabled if changes are removed.

Debugging

It seems that when snap has categories they always show up in the diff that we use to check if anything changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment