Detached tooltip #3677
Merged
Detached tooltip #3677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://vanilla-framework-3677.demos.haus |
bartaz
reviewed
Mar 31, 2021
bartaz
reviewed
Mar 31, 2021
sowasred2012
force-pushed
the
tooltip-improvements
branch
from
3707f48
to
70ba2d1
Compare
bartaz
reviewed
Mar 31, 2021
| trigger.addEventListener('mouseenter', function () { | ||
| // remove this class on mouseenter, | ||
| // rather than unnecessarily on mousemove | ||
| tooltip.classList.remove('u-hide'); |
There was a problem hiding this comment.
In theory tooltip may show up in unexpected place if mouseenter is triggered, but mousemove is not.
Not sure if it may happen, but showing and positioning should happen together.
I think moving removing the hide class name to mousemove handler should work. Or on mouseenter it should also be positioned correctly.
There was a problem hiding this comment.
馃憤 moved the setting of x and y coords to a separate function
bartaz
reviewed
Mar 31, 2021
bartaz
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Added a detached tooltip example
Fixes https://github.com/canonical-web-and-design/vanilla-squad/issues/1000
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵,Breaking Change 馃挘,Bug 馃悰,Documentation 馃摑,Maintenance 馃敤.package.jsonshould be updated relative to the most recent release, following semver convention: