Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix labels in docs for 2.35 #3964

Merged
merged 1 commit into from Sep 2, 2021
Merged

Fix labels in docs for 2.35 #3964

merged 1 commit into from Sep 2, 2021

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Sep 2, 2021 •
edited

Done

Fixes labels in side navigation and what's new page for new 2.35 release.

QA

  • Open demo
  • Make sure the "Updated" label related to Form Validation change has correct color
  • Make sure side navigation only has labels for relevant items (Forms in this case)

@bartaz bartaz added the Documentation 📝 Documentation changes or updates label Sep 2, 2021
@webteam-app
Copy link

Demo starting at https://vanilla-framework-3964.demos.haus

carkod
carkod approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@carkod carkod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartaz bartaz marked this pull request as ready for review September 2, 2021 11:45
@bartaz bartaz merged commit 9e7e04f into canonical:master Sep 2, 2021
@bartaz bartaz deleted the docs-2.35 branch September 2, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carkod carkod carkod approved these changes

Assignees
No one assigned
Labels
Documentation 📝 Documentation changes or updates Review: Code +1 Review: QA +1
Projects
None yet
Milestone
Iteration: 21-35 - 30 Aug to 10 Sep 2021
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartaz @webteam-app @carkod