New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix button width in mobile nav #4455
Fix button width in mobile nav #4455
Conversation
Demo starting at https://vanilla-framework-4455.demos.haus |
e487fa1
to
3fbd6a2
Compare
3fbd6a2
to
6100af5
Compare
@bethcollins92 thanks, looks good - but I think we should have an example in Vanilla to make sure we don't break it in future. BTW, I noticed that when you use button on a navigation dropdown it has misaligned icon, I guess because of additional margin. Maybe we can fix that as well here. |
e20cd78
to
fe62b8b
Compare
Thanks @bartaz - I've swapped the links out for buttons in the example and fixed the misaligned button |
Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Done
p-navigation__link
when used on a button elementFixes #4444
QA
p-navigation__link
on a button element, wrapped in a<li class="p-navigation__item"></li>
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention: