This repository has been archived by the owner on Jun 11, 2020. It is now read-only.
Return pending build requests from getSnapBuilds #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the UI to show the user that there's a pending build request, rather than appearing unresponsive in the interval between a set of builds being requested and the request being processed. The database gains a new `build_request_annotation` table, allowing us to keep track of build reasons even when the process of creating new builds goes through a build request. I'd like to return failed build requests as well, but there are some significant complications involved in making that work efficiently in conjunction with pagination, mainly on the Launchpad side. I don't think that needs to block the rest of this work. Part of canonical-web-and-design#556.
bartaz
approved these changes
Oct 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the UI to show the user that there's a pending build
request, rather than appearing unresponsive in the interval between a
set of builds being requested and the request being processed.
The database gains a new
build_request_annotationtable, allowing usto keep track of build reasons even when the process of creating new
builds goes through a build request.
I'd like to return failed build requests as well, but there are some
significant complications involved in making that work efficiently in
conjunction with pagination, mainly on the Launchpad side. I don't
think that needs to block the rest of this work.
Part of #556.
QA
Since there's no way to create build requests from BSI yet, QA can consist of making sure that dispatching new builds still works and that the UI updates properly.