Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cssnano dep #112

Merged
merged 2 commits into from Feb 21, 2019
Merged

Remove cssnano dep #112

merged 2 commits into from Feb 21, 2019

Conversation

barrymcgee
Copy link
Contributor

Done

  • Remove cssnano dep
  • Use --output-style compressed with node-sass instead

QA

  • Run this feature branch
  • Run ./run build
  • Ensure no errors

@barrymcgee barrymcgee mentioned this pull request Feb 20, 2019
Closed
1 task
@webteam-app
Copy link

Starting demo at: https://jp-ubuntu-com-canonical-websites-pr-112.run.demo.haus/

anthonydillon
anthonydillon requested changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but suggestion to quarter the css filesize

package.json Outdated Show resolved Hide resolved
@anthonydillon anthonydillon self-assigned this Feb 20, 2019
@anthonydillon
Copy link
Contributor

@barrymcgee I don't see the change applied.

@barrymcgee
Copy link
Contributor Author

@anthonydillon Sorry - don't know what happened.. should be changed now.

anthonydillon
anthonydillon approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@barrymcgee barrymcgee merged commit c6091ce into canonical:master Feb 21, 2019
@barrymcgee barrymcgee deleted the remove-cssnano branch February 21, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nottrobin nottrobin nottrobin left review comments

@anthonydillon anthonydillon anthonydillon approved these changes

Assignees

@anthonydillon anthonydillon

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@barrymcgee @webteam-app @anthonydillon @nottrobin