Add search endpoint #135
Merged
Add search endpoint #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting demo at: http://snapcraft.io-pr-135.run.demo.haus/ |
|
@nottrobin I discussed with @bartaz I will add a commit to filter and normalize the informations I send to the template. |
|
I have 2 bugs on the snap search API:
Here is an example of what is returned: Here is what I would expect: The |
|
I got a JSON decode error. I'll keep looking tomorrow. |
|
This are the informations that are given to the template: |
nottrobin
suggested changes
Nov 9, 2017
templates/snap-search.html
Outdated
|
|
||
| {% block title %}{{ snap_title }} — Linux software in the Snap Store{% endblock %} | ||
|
|
||
| {% block content %} |
There was a problem hiding this comment.
Could we give the frontends slightly more to work with, with a template something like this?
{% block content %}
<ul>
{% for snap in snaps %}
<li>
<h3>{{ snap.title }}</h1>
<table>
{% for key, value in snap.items() %}
<tr>
<th>{{ key }}</th>
<td>{{ value }}</td>
</tr>
{% endfor %}
</table>
</li>
{% endfor %}
<nav>
{% if links.first %}<a href="{{ links.first }}">First</a>{% endif %}
{% if links.prev %}<a href="{{ links.prev }}">Previous</a>{% endif %}
{% if links.next %}<a href="{{ links.next }}">Next</a>{% endif %}
{% if links.last %}<a href="{{ links.last }}">Last</a>{% endif %}
</nav>
{% endblock %}
templates/snap-search.html
Outdated
| @@ -0,0 +1,7 @@ | |||
| {% extends "_layout.html" %} | |||
There was a problem hiding this comment.
Do you mind if we call this file simply "search.html"?
|
Basic template added #113 |
nottrobin
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added the search endpoint on the server. It renders a temporary page that diplays a JSON of the searched result. For the moment the search response isn't modified from what I receive from the snapcraft search API.
QA
./run