Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin integration tests deployed dependencies of repos [11-20] #864

Closed
DnPlas opened this issue Apr 9, 2024 · 1 comment
Closed

Pin integration tests deployed dependencies of repos [11-20] #864

DnPlas opened this issue Apr 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Apr 9, 2024

Context

All the charms that get deployed as dependencies in integration tests must be pinned to their corresponding 1.8 stable channels in the gh:track/ branches. For instance, istio-operators deploy kubeflow-volumes in their integration tests, we must ensure that the last supported stable version of kubeflow-volumes get deployed alongside the last supported stable istio-operators.

Please follow these standards:

For variable naming:

ISTIO_CHANNEL = "1.17/stable"
ISTIO_PILOT = "istio-pilot"
ISTIO_PILOT_TRUST = True
ISTIO_GATEWAY = "istio-gateway"
ISTIO_GATEWAY_APP_NAME = "istio-ingressgateway"
ISTIO_GATEWAY_TRUST = True

For pinning COS charms:

In track/<version> pin the most stable version 1.0/stable and in main please pin the latest/stable version.

You could add a constants.py file to list all the variables and their values and import constants as a module from . import constants so you can use it in your code as constants.SOME_VAR_NAME.

What needs to get done

For gh:track/<version> (for CKF 1.8 corresponding versions)

  1. Get charms 11-20 from the bundle.yaml file.
  2. Go into each charm repo and for all the test.py files where a charm is deployed, pin the channel to the version defined in the bundle definition (file from step 1).
  3. Submit a PR with your changes.

For gh:main make sure all charms that get deployed in integration tests point to latest/stable unless it is recommended otherwise (e.g. mysql-k8s).

Definition of Done

All integration tests run with specific versions of charms that correspond to either CKF 1.8 or latest/stable (or recommended version)

@DnPlas DnPlas added the enhancement New feature or request label Apr 9, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5539.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants