You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All the charms that get deployed as dependencies in integration tests must be pinned to their corresponding 1.8 stable channels in the gh:track/ branches. For instance, istio-operators deploy kubeflow-volumes in their integration tests, we must ensure that the last supported stable version of kubeflow-volumes get deployed alongside the last supported stable istio-operators.
In track/<version> pin the most stable version 1.0/stable and in main please pin the latest/stable version.
You could add a constants.py file to list all the variables and their values and import constants as a module from . import constants so you can use it in your code as constants.SOME_VAR_NAME.
While some of the integration tests may pass, the correct way of running integration tests to keep repeatable runs is by testing always with the same versions.
Go into each charm repo and for all the test.py files where a charm is deployed, pin the channel to the version defined in the bundle definition (file from step 1).
Submit a PR with your changes.
For gh:main make sure all charms that get deployed in integration tests point to latest/stable unless it is recommended otherwise (e.g. mysql-k8s).
Definition of Done
All integration tests run with specific versions of charms that correspond to either CKF 1.8 or latest/stable (or recommended version)
The text was updated successfully, but these errors were encountered:
Context
All the charms that get deployed as dependencies in integration tests must be pinned to their corresponding 1.8 stable channels in the gh:track/ branches. For instance, istio-operators deploy kubeflow-volumes in their integration tests, we must ensure that the last supported stable version of kubeflow-volumes get deployed alongside the last supported stable istio-operators.
Please follow these standards:
For variable naming:
For pinning COS charms:
In
track/<version>
pin the most stable version1.0/stable
and inmain
please pin thelatest/stable
version.You could add a
constants.py
file to list all the variables and their values and import constants as a modulefrom . import constants
so you can use it in your code asconstants.SOME_VAR_NAME
.While some of the integration tests may pass, the correct way of running integration tests to keep repeatable runs is by testing always with the same versions.
Related issue CKF 1.9: Pin the charm dependencies in the integration tests of the
track/<version>
branches #857Part of Bump juju 3.1 -> 3.5 #859
What needs to get done
For
gh:track/<version>
(for CKF 1.8 corresponding versions)bundle.yaml
file.test.py
files where a charm is deployed, pin the channel to the version defined in the bundle definition (file from step 1).For
gh:main
make sure all charms that get deployed in integration tests point tolatest/stable
unless it is recommended otherwise (e.g.mysql-k8s
).Definition of Done
All integration tests run with specific versions of charms that correspond to either CKF 1.8 or
latest/stable
(or recommended version)The text was updated successfully, but these errors were encountered: