Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard output of the Chip Tool command not in test artifacts #33

Closed
farshidtz opened this issue Jan 18, 2024 · 3 comments · Fixed by #45
Closed

Standard output of the Chip Tool command not in test artifacts #33

farshidtz opened this issue Jan 18, 2024 · 3 comments · Fixed by #45
Labels
bug Something isn't working CI Continuous Integration

Comments

@farshidtz
Copy link
Member

Looking at the latest run here, I noticed that the chip-tool logs produced as artifacts only include the journal logs. The standard output of the Chip Tool command isn't collected.

Originally posted by @farshidtz in #31 (comment)

@farshidtz farshidtz added bug Something isn't working CI Continuous Integration labels Jan 18, 2024
@MonicaisHer
Copy link
Contributor

Where is the best place to output the chip tool command's stdout? Directly in the chip-tool test suite when calling utils.Exec(), or as part of the utils .exec()?

@farshidtz
Copy link
Member Author

Where is the best place to output the chip tool command's stdout? Directly in the chip-tool test suite when calling utils.Exec(), or as part of the utils .exec()?

The issue isn't about printing the logs. The utils.exec function executes the command and returns the logs. It already supports printing of the log stream.

@MonicaisHer
Copy link
Contributor

MonicaisHer commented Jan 31, 2024

There are two places where the stdout log can be exported—either on the chip-tool test side or on the matter-snap-testing side (similar to SnapDumpLogs). It could probably be placed on the matter-snap-testing side for reusability. However, the current Matter snaps (OTBR snap and GPIO snap) already collect all the syslog using SnapDumpLogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants