'noblock' setting for resize_rootfs is broken

[ubuntu-server-builder]

This bug was originally filed in Launchpad as LP: #1080985

Launchpad details

affected_projects = ['cloud-init (Ubuntu)', 'cloud-init (Ubuntu Quantal)']
assignee = None
assignee_name = None
date_closed = 2013-05-15T19:58:31.388731+00:00
date_created = 2012-11-20T05:04:03.889109+00:00
date_fix_committed = 2012-11-20T06:06:51.617831+00:00
date_fix_released = 2013-05-15T19:58:31.388731+00:00
id = 1080985
importance = medium
is_complete = True
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1080985
milestone = None
owner = smoser
owner_name = Scott Moser
private = False
status = fix_released
submitter = smoser
submitter_name = Scott Moser
tags = ['verification-done']
duplicates = []

Launchpad user Scott Moser(smoser) wrote on 2012-11-20T05:04:03.889109+00:00

== Begin SRU Information ==
[Impact]

• Users who want to run filesystem resize without blocking first boot are not able to. This is admittedly small impact, but is clearly broken code.

[TestCase]

• launch an instance with userdata like:
  #cloud-config
  resize_rootfs: noblock
• run 'df' in instance, see root filesystem is not resized
• see /var/log/cloud-init.log showing that resizefs was ignored.

[Regression Potential]

• small chance for regression. Previous code checked a small list of values for a boolean value, and did nothing if it was not "true". The change extends the check to also consider 'noblock'.
  == End SRU Information ==

resize_rootfs: noblock

should tell the resize to occur in the background, but it will currently result in:
Nov 20 04:51:45 ubuntu [CLOUDINIT] cc_resizefs.py[DEBUG]: Skipping module named resizefs, resizing disabled

The fix is simple, in cloudinit/config/cc_resizefs.py:

    log.warn("resize_root: %s" % resize_root)
    if not util.translate_bool(resize_root) and resize_root not in ("noblock"):
        log.debug("Skipping module named %s, resizing disabled", name)
        return

[ubuntu-server-builder]

Launchpad user Scott Moser(smoser) wrote on 2012-11-20T06:06:50.764369+00:00

fixed revno 743.

[ubuntu-server-builder]

Launchpad user Launchpad Janitor(janitor) wrote on 2012-12-04T03:14:15.684076+00:00

This bug was fixed in the package cloud-init - 0.7.1-0ubuntu3

---

cloud-init (0.7.1-0ubuntu3) raring; urgency=low

• cherry pick relevant patches from trunk up to revision 745
• fix writing of sudoers when suders rule is a string rather than
  an array (LP: #1079002)
• add trailing slash to sudoers files that are written
• fix resizefs module when 'noblock' was provided (LP: #1080985)
• make sure there is no blank line before cloud-init entry in
  there are no blank lines in /etc/ca-certificates.conf (LP: #1077020)
  -- Scott Moser smoser@ubuntu.com Mon, 03 Dec 2012 21:45:48 -0500

[ubuntu-server-builder]

Launchpad user Clint Byrum(clint-fewbar) wrote on 2012-12-13T20:31:08.505044+00:00

Hello Scott, or anyone else affected,

Accepted cloud-init into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/cloud-init/0.7.0-0ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[ubuntu-server-builder]

Launchpad user Clint Byrum(clint-fewbar) wrote on 2013-01-08T19:07:29.118767+00:00

Hello Scott, or anyone else affected,

Accepted cloud-init into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/cloud-init/0.7.0-0ubuntu2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[ubuntu-server-builder]

Launchpad user Colin Watson(cjwatson) wrote on 2013-01-16T14:21:05.087567+00:00

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

[ubuntu-server-builder]

Launchpad user Launchpad Janitor(janitor) wrote on 2013-01-16T14:21:09.774131+00:00

This bug was fixed in the package cloud-init - 0.7.0-0ubuntu2.2

---

cloud-init (0.7.0-0ubuntu2.2) quantal-proposed; urgency=low

• debian/patches/lp-1090482-fix-cloud-config-mirrors.patch:
  fix issue with cloud-config data in user-data providing mirror
  info (LP: #1073077)

cloud-init (0.7.0-0ubuntu2.1) quantal-proposed; urgency=low

• debian/patches/lp-1073077-zsh-workaround-for-locale_warn.patch: avoid
  warning when user's shell is zsh (LP: #1073077)
• debian/patches/lp-1077700-config-drive-fix-ssh-authorized-keys.patch:
  fix bug in config-drive-v2 usage of authoried keys (LP: #1077700)
• debian/patches/lp-1080985-fix-resize-root-noblock.patch:
  fix 'resize_root: noblock' (LP: #1080985)
• debian/patches/lp-1076811-fix-userdata-update-to-distro-config.patch:
  fix updates to distro config via user-data. (LP: #1076811)
• debian/patches/lp-1066115-install-landscape-if-needed.patch:
  fix permissions on landscape config, and ensure landscape client
  is installed if landscape config is given. (LP: #1066115)
• debian/patches/lp-1070345-restart-landscape-if-needed.patch:
  restart the landscape-client if changes to config were made. (LP: #1070345)
• debian/patches/lp-1077020-fix-ca-certificates-blanklines.patch: fix
  adding of empty lines in ca-certificates file (LP: #1077020)
  -- Scott Moser smoser@ubuntu.com Mon, 17 Dec 2012 10:15:03 -0500

[ubuntu-server-builder]

Launchpad user Scott Moser(smoser) wrote on 2013-05-15T19:58:30.099842+00:00

fixed in 0.7.2